BuddyDev

Search

Font Awesome Icons in Main Navigation

Tagged: ,

  • Keymaster
    (BuddyDev Team)
    Posts: 24232
    Brajesh Singh on April 4, 2019 at 4:28 pm #21907

    Hi Jessica,
    Thank you.

    I have checked it now. I am publishing another update by Saturday that will resolve it.
    yes, It is a plugin compatibility issue. The problem is we are using a custom nav walker and the nav icon plugin is injecting their icon in our right floated icon class.

    Is this the plugin in question?
    https://wordpress.org/plugins/font-awesome-4-menus/

    Please let me know and I will publish an update by Saturday or early.

    Thank you
    Brajesh

  • Participant
    Level: Enlightened
    Posts: 40
    Jessica Martin on May 3, 2019 at 12:35 pm #22745

    Are you able to take a look at the fix for this when using a menu in the left panel? The Font Awesome icon is pushed to the right and when you expand the menu, it rotates the icon on it’s side. You can see it here: http://tinyurl.com/yyr4tp6l (I have the left panel set to only display on small screens, so you will need to reduce window size to see.)

  • Keymaster
    (BuddyDev Team)
    Posts: 24232
    Brajesh Singh on May 3, 2019 at 4:32 pm #22754

    Hi Jessica,
    I will put a fix this weekend/Monday.

    Regards
    Brajesh

  • Participant
    Level: Enlightened
    Posts: 40
    Jessica Martin on June 5, 2019 at 11:45 am #23371

    Hello again,

    Have you pushed an update with this recently?

    Regards,

    Jessica

  • Keymaster
    (BuddyDev Team)
    Posts: 24232
    Brajesh Singh on June 6, 2019 at 12:58 am #23376

    Hi Jessica,
    Thank you for the reply.

    I don’t see a workaround without modifying code.

    The plugin is filtering on ‘walker_nav_menu_start_el’ and using regular expression to inject the font awesome markup.

    The problem is our custom nav walker for the panel menus return custom links(containing font awesome markup itself).

    That makes the plugins regular expression go wrong.

    The only solution I see is modifying the cb-nav-walker.php and removing our code for adding icon.

    You will need to comment line 139 from

    
$item_output .= $fa_item;

    to

    

//$item_output .= $fa_item;

    and also modify line 142 from

    
$item_output .= ( $args->has_children && 0 === $depth ) ? ' <i class="fa fa-angle-left pull-right"></i></a>' : '</a>';

    to

    
$item_output .= '</a>';

    That will make it work.

    Regards
    Brajesh

You must be logged in to reply to this topic.

This topic is: not resolved